Remove _result_properties #2365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 24a14f3.
rafacanton
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2365 +/- ##
==========================================
+ Coverage 84.37% 84.42% +0.04%
==========================================
Files 92 92
Lines 10922 10912 -10
==========================================
- Hits 9215 9212 -3
+ Misses 1707 1700 -7 |
rafacanton
changed the title
PProfizi
approved these changes
Nov 5, 2025
|
Some tests with 'continue-on-error: true' have failed:
Created by continue-on-error-comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we eliminate the hardcoded
_result_propertiesdictionary as per the attached issue. This is aligned with this PR in pydpf-post: ansys/pydpf-post#918